Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Page Builder Improvements (@container, Emotion Context, Theme-aware mq Utility Function) #3141

Merged
merged 38 commits into from Mar 31, 2023

Conversation

adrians5j
Copy link
Member

@adrians5j adrians5j commented Mar 27, 2023

Changes

This PR introduces the usage of Page Builder improvements:

  • use @container rules to enable responsive design Page Builder's page editor
  • ensures theme is being passed to custom Emotion styled components
  • introduces the mq and useFacepaint utility functions to @webiny/app-page-builder-elements package

How Has This Been Tested?

Manually / relying on existing tests.

Documentation

Changelog. Theming documentation.

@adrians5j adrians5j changed the base branch from next to 535-emo11 March 27, 2023 09:28
@adrians5j adrians5j changed the title Use @Container Rules to Enable Responsive Design Within Both Website and Page Builder's Page Editor Use @container Rules to Enable Responsive Design Within Both Website and Page Builder's Page Editor Mar 27, 2023
@adrians5j adrians5j self-assigned this Mar 28, 2023
@adrians5j adrians5j marked this pull request as ready for review March 28, 2023 13:18
@adrians5j adrians5j changed the title Use @container Rules to Enable Responsive Design Within Both Website and Page Builder's Page Editor Multiple Page Builder Improvements (@container, Emotion Context, Theme-aware mq Utility Function) Mar 28, 2023
@adrians5j
Copy link
Member Author

/cypress

@github-actions
Copy link

Cypress E2E tests have been initiated (for more information, click here). ✨

@adrians5j adrians5j changed the base branch from 535-emo11 to next March 31, 2023 06:48
@adrians5j adrians5j merged commit 18ed331 into next Mar 31, 2023
58 checks passed
@adrians5j adrians5j deleted the 535-container branch June 5, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant