Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-admin-cognito): add error to DefaultContent component props #4174

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

leopuleo
Copy link
Contributor

Changes

With this PR, we fix an error encountered when using the useSignIn() hook in multiple components. The hook does not use any context provider, so it does not sync data cached like the error returned by the API.

With this change, we pass error to the DefaultContent component from its parent SignIn.

How Has This Been Tested?

Manually

@leopuleo leopuleo added this to the 5.40.0 milestone Jun 18, 2024
@leopuleo leopuleo requested a review from Pavel910 June 18, 2024 12:57
@leopuleo leopuleo self-assigned this Jun 18, 2024
@Pavel910 Pavel910 merged commit 8ad56da into next Jun 18, 2024
91 of 93 checks passed
@leopuleo leopuleo deleted the leo/fix/signin-error-content branch July 5, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants