Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add word-break to editor paragraphs #765

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Add word-break to editor paragraphs #765

merged 1 commit into from
Mar 15, 2023

Conversation

norbye
Copy link
Member

@norbye norbye commented Mar 15, 2023

Prevents long words and paragraphs to overflow the editor.

Tested by adding the selector in prod, and worked out pretty well.

@norbye norbye added bug-fix Pull requests that fix a bug review-needed Pull requests that need review labels Mar 15, 2023
ivarnakken
ivarnakken approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ivarnakken ivarnakken added approved Pull requests that have been approved and removed review-needed Pull requests that need review labels Mar 15, 2023
@norbye norbye merged commit 1f752ac into master Mar 15, 2023
@norbye norbye deleted the overflow branch March 15, 2023 11:31
norbye added a commit that referenced this pull request Mar 15, 2023
@norbye
v2.1.0
2dfb20e 
New features
* The editor now supports strikethrough text (#741)

Fixes
* Fix paragraph overflow on long words (#765)
* Fix invisible text in link input when using dark mode (#647)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarnakken ivarnakken ivarnakken approved these changes

@LudvigHz LudvigHz LudvigHz approved these changes

@eikhr eikhr Awaiting requested review from eikhr

@ingraso ingraso Awaiting requested review from ingraso

Assignees
No one assigned
Labels
approved Pull requests that have been approved bug-fix Pull requests that fix a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@norbye @LudvigHz @ivarnakken