Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Contact Tracing Field in EventEditor #4231

Closed
wants to merge 1 commit into from

Conversation

AdrianAndersen
Copy link
Member

Description

This PR hides the field for contact tracing, so that no one can enable it by mistake. I think the rest of the functionality should remain in the codebase though, so it is really easy to just make this visible if we ever encounter another pandemic.

Result

The field in the EventEditor is hidden.

Testing

  • I have thoroughly tested my changes.

Resolves ABA-183

@AdrianAndersen AdrianAndersen added the chore Pull requests that does something "boring", yet important, e.g. cleaning up code label Oct 24, 2023
@AdrianAndersen AdrianAndersen self-assigned this Oct 24, 2023
@linear
Copy link

linear bot commented Oct 24, 2023

ABA-183 Remove the "smittesporing" field from events

To prevent people from clicking on it.

@github-actions github-actions bot added the review-needed Pull requests that need review label Oct 24, 2023
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just remove it, and we'll revert the commit if it comes to that

@AdrianAndersen
Copy link
Member Author

Sure, we can do that. I assume you mean to remove all traces of the contact_tracing functionality, including the backend models, @ivarnakken?

@ivarnakken
Copy link
Member

ivarnakken commented Oct 24, 2023

Sure, we can do that. I assume you mean to remove all traces of the contact_tracing functionality, including the backend models, @ivarnakken?

Yes please

@ivarnakken ivarnakken added the changes-requested Pull requests with requested changes label Oct 26, 2023
@AdrianAndersen
Copy link
Member Author

Superseded by #4476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-requested Pull requests with requested changes chore Pull requests that does something "boring", yet important, e.g. cleaning up code review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants