Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LeNet example #1

Merged
merged 13 commits into from
Sep 22, 2020
Merged

Add LeNet example #1

merged 13 commits into from
Sep 22, 2020

Conversation

huningxin
Copy link
Contributor

Fix webmachinelearning/webnn#70

To facilitate the review, a working version is hosted at: https://huningxin.github.io/webnn-samples/lenet/

This example is based on the foundation webnn-polyfill in webmachinelearning/webnn-polyfill#1

@anssiko @wchao1115 @pyu10055, please take a look. Thanks!

@anssiko
Copy link
Member

anssiko commented Sep 3, 2020

Thanks looks great! Small nit on narrow screens, e.g. mobile: I suggest you use CSS media queries to position prediction results and controls underneath the image on narrow screens. Currently, they're overlaid on top of the image on mobile, and as such, unreadable.

Copy link

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks Ningxin, this looks good, is it possible to provide a work demo url to try this out?

lenet/index.html Outdated Show resolved Hide resolved
lenet/index.html Show resolved Hide resolved
lenet/lenet.js Outdated Show resolved Hide resolved
@huningxin
Copy link
Contributor Author

THanks Ningxin, this looks good, is it possible to provide a work demo url to try this out?

https://huningxin.github.io/webnn-samples/lenet/

@huningxin
Copy link
Contributor Author

@anssiko , I fixed the UI issue on narrow screens. I also updated the live version with this fix. Please take a look.

A screenshot:
image

@anssiko
Copy link
Member

anssiko commented Sep 4, 2020

Looks great now also on narrow screens, thanks!

lenet/lenet.js Outdated Show resolved Hide resolved
lenet/README.md Outdated Show resolved Hide resolved
lenet/README.md Outdated Show resolved Hide resolved
@huningxin
Copy link
Contributor Author

According to the resolution 01 of WebML CG call on 9/17

RESOLUTION: Land WebNN polyfill and samples PRs when existing review comments have been addressed, do not block on in-flight spec PRs and API design discussion

All of the review comments by @pyu10055 have been addressed, so I suppose it is ready to merge. @anssiko , WDYT?

@anssiko
Copy link
Member

anssiko commented Sep 22, 2020

We’re ready to land. Thanks!

@huningxin
Copy link
Contributor Author

Thanks @anssiko , I am going to merge this PR.

@huningxin huningxin merged commit 2a2f951 into webmachinelearning:master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a more advanced example
3 participants