-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LeNet example #1
Conversation
Thanks looks great! Small nit on narrow screens, e.g. mobile: I suggest you use CSS media queries to position prediction results and controls underneath the image on narrow screens. Currently, they're overlaid on top of the image on mobile, and as such, unreadable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THanks Ningxin, this looks good, is it possible to provide a work demo url to try this out?
|
@anssiko , I fixed the UI issue on narrow screens. I also updated the live version with this fix. Please take a look. |
Looks great now also on narrow screens, thanks! |
According to the resolution 01 of WebML CG call on 9/17
All of the review comments by @pyu10055 have been addressed, so I suppose it is ready to merge. @anssiko , WDYT? |
We’re ready to land. Thanks! |
Thanks @anssiko , I am going to merge this PR. |
Fix webmachinelearning/webnn#70
To facilitate the review, a working version is hosted at: https://huningxin.github.io/webnn-samples/lenet/
This example is based on the foundation webnn-polyfill in webmachinelearning/webnn-polyfill#1
@anssiko @wchao1115 @pyu10055, please take a look. Thanks!