-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make operand data type and rank validation table-driven #657
base: main
Are you sure you want to change the base?
Make operand data type and rank validation table-driven #657
Conversation
31410f3
to
48b240b
Compare
Improve readability of input operand data type and rank by introducing a table within each method definition that outlines the restrictions for positional arguments and options. Steps are updated to reference the table columns.
c8b4ac2
to
7f2e78b
Compare
I'd prefer this style than the one in #646 |
A few questions to consider: dataType
rank
General
|
IMHO the "consistent" option is clear enough in this case. :) |
- gemm(): Fix ranks in table, align phrasing. - gru(): Align phrasing. - lstm(): Don't inline rank of 3, reference table. - matmul(): Align phrasing. - prelu(): Fix punctation. - triangular(): Add table, use for rank validation. - where(): Align phrasing.
4c13bf8
to
295cd0b
Compare
Other notes:
|
Looking at the preview, I think that makes sense.
Shape should include rank... I'd leave rank out and let impl optionally handle that as a quick check, if it makes sense somewhere. |
Quick update here - It seems like folks are happy with this direction. I've been keeping this PR up-to-date and it is theoretically good to merge any time, but given that it will interact a lot with eventual spec text for #463 ( |
Understood.
It will be beautiful. |
Improve readability of input operand data type and rank by introducing a table within each method definition that lines the restrictions for positional arguments and options. Steps are updated to reference the table columns.
Preview | Diff