Write example decompositions as complete functions #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it clearer how the example decompositions map to the methods they are defining - variables are explicitly named as parameters, or unpacked from the arguments. No normative changes.
|
@huningxin & @fdwr - please take a look? |
fdwr
approved these changes
Jun 18, 2024
|
FYI I'll look into lint tooling to help enforce this, but I didn't want to block on it. The easiest might be pulling eslint in as another node dependency, if that doesn't seem too bad. |
|
Yes, that sets a nice and clear context to the code snippets. |
huningxin
reviewed
Jun 24, 2024
|
@huningxin take another look, and merge if it looks good? Thanks! |
fdwr
approved these changes
Jun 24, 2024
huningxin
reviewed
Jun 25, 2024
index.bs
Outdated
| @@ -5950,8 +5945,9 @@ partial interface MLGraphBuilder { | |||
| function where(builder, condition, input, other) { | |||
| const c = builder.clamp(condition, {'minValue': 0, 'maxValue': 1}); | |||
| builder.add( | |||
| builder.mul(input, builder.cast(c, input.dataType())), | |||
| builder.mul(other, builder.cast(builder.logicalNot(c), other.dataType()))); | |||
There was a problem hiding this comment.
The above two lines were good and won't need to change.
fdwr
reviewed
Jun 25, 2024
huningxin
approved these changes
Jun 25, 2024
github-actions bot
added a commit
that referenced
this pull request
Jun 25, 2024
SHA: 588a728 Reason: push, by huningxin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it clearer how the example decompositions map to the methods they are defining - variables are explicitly named as parameters, or unpacked from the arguments.
Also fix code treating MLOperand's dataType() as a getter instead of a method.
No normative changes.
Preview | Diff