Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StyleCI checks #223

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Fix StyleCI checks #223

merged 2 commits into from
Dec 2, 2020

Conversation

andrew-demb
Copy link
Contributor

No description provided.

Nyholm
Nyholm reviewed Nov 20, 2020
View reviewed changes
Copy link
Contributor

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. I just have some questions

bin/src/MixinGenerator.php Show resolved Hide resolved
bin/src/MixinGenerator.php Show resolved Hide resolved
BackEndTea
BackEndTea approved these changes Dec 2, 2020
View reviewed changes
Copy link
Collaborator

@BackEndTea BackEndTea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I think i'd like to get rid of styleci, in favor of just having php code sniffer or php code style fixer as a dependency. But this is fine, and fixes the issues at hand 👍

@BackEndTea BackEndTea merged commit 088006b into webmozarts:master Dec 2, 2020
@andrew-demb andrew-demb deleted the styleci-fix branch December 2, 2020 18:32
This was referenced Mar 10, 2021
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm left review comments

@Ocramius Ocramius Ocramius approved these changes

@BackEndTea BackEndTea BackEndTea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrew-demb @Ocramius @Nyholm @BackEndTea