Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrapEmoji fixes and improvements #43

Merged
merged 2 commits into from
May 3, 2024
Merged

fix: wrapEmoji fixes and improvements #43

merged 2 commits into from
May 3, 2024

Conversation

pauldps
Copy link
Contributor

@pauldps pauldps commented May 3, 2024 •
edited
Loading

wrapEmoji:

  • Now using https://github.com/mathiasbynens/emoji-regex to scan for emoji
  • Fixed non-encoding emoji not being detected
  • Method and constants moved to its own file since it has external dependencies
  • Added more specs to ensure non-unicode emoji get wrapped correctly

@pauldps pauldps merged commit aca1750 into main May 3, 2024
3 checks passed
@pauldps pauldps deleted the emoji-fix-2 branch May 3, 2024 20:52
@github-actions github-actions bot mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pauldps