Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field definition for InputTypeObject does not work with callback function #22

Closed
ivome opened this issue Feb 23, 2016 · 2 comments
Closed

Comments

@ivome
Copy link
Contributor

ivome commented Feb 23, 2016

Sometimes the fields do not get added to an InputObjectType when they are defined as a callback.

Specific example:
https://github.com/ivome/graphql-relay-php/blob/master/src/Mutation/Mutation.php#L47

If we change that to a function, the test suite fails because the fields do not get added. For the normal ObjectType this seems to work as you can see a few lines after that.

@vladar
Copy link
Member

vladar commented Feb 24, 2016

Should be fixed in b890ef7

@ivome
Copy link
Contributor Author

ivome commented Feb 26, 2016

Awesome, thanks for the quick fix! I found one more for InterfaceType, besides that, all other closure issues seem to be resolved with the latest fix. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants