Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added brotli support via iltorb #31

Closed
wants to merge 1 commit into from
Closed

added brotli support via iltorb #31

wants to merge 1 commit into from

Conversation

mynameiswhm
Copy link

No description provided.

@mynameiswhm
Copy link
Author

what's up with default travis configuration? :)

@palmerj3
Copy link
Contributor

@mynameiswhm thank you!

I'm a bit uncomfortable adding an additional optionalDependency. TBH I don't like that we have an optionalDependency already for node-zopfli. Unless there is a failure of install you are guaranteed to add ~8mb to the bundle. I'll leave this open for now and ask for others to comment so I know what kind of support this has.

My opinion is that each unique compression should be a separate compression plugin instead of this plugin providing a factory-like interface to a bunch of optional dependencies.

@mynameiswhm
Copy link
Author

@palmerj3 fair enough, that's kind of makes sense!

I think i'm going to make a separate plugin for this tomorrow, but yeah,let's hear another maintainers' opinions :)

@mynameiswhm
Copy link
Author

ok, I've created brotli-webpack-plugin, closing the pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants