-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use posix path as assets key #378
Conversation
Why? What is problem? |
Don't use |
I think the key of assets should be treated as path of url instead of path of filesystem. Regarding the third point, the value of 'to' may be 'js' (a dir), And my configuration in ‘tags’ is still expected to be ‘js/xxx.js’ And the first and second points are also important reasons, especially the first point. |
@snadn no, linux support |
@evilebottnawi But this is just that this pr modification is not good enough, but using ‘/’ is still more reasonable. Maybe getting posix path and record it when getting the file path will be better. ps: just change the key of assets will break cache? Whether it is in window or linux, the keys obtained are the same.The potential problem should be that multiple files may be mapped to a key |
|
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
- Coverage 94.82% 94.53% -0.29%
==========================================
Files 9 9
Lines 290 293 +3
Branches 78 81 +3
==========================================
+ Hits 275 277 +2
- Misses 14 15 +1
Partials 1 1
Continue to review full report at Codecov.
|
@evilebottnawi Can this pr be merged? |
Looks like related #383 |
I was going to file a PR (see https://github.com/webpack-contrib/copy-webpack-plugin/compare/master...jeffposnick:windows-fix?expand=1) but I see that this PR should address it just as well. |
This PR contains a:
Motivation / Use-Case
should use posix path as assets key that consistent with webpack
Breaking Changes
Additional Info