feat: support flat config #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #238 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 283 291 +8
Branches 78 81 +3
=========================================
+ Hits 283 291 +8 ☔ View full report in Codecov by Sentry. |
|
@onigoetz Very good |
onigoetz
force-pushed
the
flat-config-support
branch
from
b9844d0
to
66e1e8c
Compare
ricardogobbosouza
requested changes
Dec 23, 2023
Sure, done :) However, I'm not sure why Node 16 is failing :/ |
|
@onigoetz the message of your commits must be in lowercase letters |
onigoetz
force-pushed
the
flat-config-support
branch
from
796ae62
to
18a45cb
Compare
|
@ricardogobbosouza sure, done |
ricardogobbosouza
force-pushed
the
flat-config-support
branch
3 times, most recently
from
b73050f
to
65f095a
Compare
|
Using node 18 have the error |
ricardogobbosouza
force-pushed
the
flat-config-support
branch
from
eda7a3b
to
8fc1d2d
Compare
|
It is the problem of jest, it is sad, yeah, just skip it for old nodes |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
As explained in #190, ESLint has a new config system.
This is meant to be the future default but it does not work out of the box.
This PR aims to allow the usage of flat configuration for pioneers while being future proof at the same time.
Breaking Changes
None
Additional Info
The new API is documented here: https://eslint.org/blog/2022/08/new-config-system-part-3/
Changes introduced by this PR:
configTypeoption to allow to switch between the legacy and future way of loading configurationworker.js(was duplicated ingetESLint.jsas well)Each change is in its own commit, you can review them separately.
This replaces #237.
Once this one is merged I'd happily make another PR for the changes I proposed in tests, but let's not pile everything together.