Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of flat config #237

Closed
wants to merge 4 commits into from
Closed

Allow usage of flat config #237

wants to merge 4 commits into from

Conversation

onigoetz
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

As explained in #190, ESLint has a new config system.
This is meant to be the future default but it does not work out of the box.

This PR aims to allow the usage of flat configuration for pioneers while being future proof at the same time.

Breaking Changes

None

Additional Info

The new API is documented here: https://eslint.org/blog/2022/08/new-config-system-part-3/

Changes introduced by this PR:

  • new configType option to allow to switch between the legacy and future way of loading configuration
  • changed tests to use async/await where possible, to not wait for the timeout to see the errors
  • moved all code to load eslint to worker.js (was duplicated in getESLint.js as well)

Each change is in its own commit, you can review them separately.

I decided to pile this PR on top of #229 because it changes the same areas

@alexander-akait
Copy link
Member

@ricardogobbosouza Hello, can you look at this?

@ricardogobbosouza
Copy link
Collaborator

Thanks @onigoetz
It might be better to base it on the master branch.
I will do this to separate the PRs

@onigoetz
Copy link
Contributor Author

sure, I'll make a separate one that's based on master

@onigoetz onigoetz mentioned this pull request Dec 23, 2023
6 tasks
@onigoetz
Copy link
Contributor Author

Hi @ricardogobbosouza, in the end it was quicker than I expected, I opened #238 with the minimal amount of changes required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants