This repository has been archived by the owner on May 29, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 512
fix: add missing options.ignoreOrder
details in Error message
#539
Merged
michael-ciniawsky
merged 1 commit into
webpack-contrib:master
from
gl2748:gl2748/ignoreOrder
Jun 10, 2017
Merged
fix: add missing options.ignoreOrder
details in Error message
#539
michael-ciniawsky
merged 1 commit into
webpack-contrib:master
from
gl2748:gl2748/ignoreOrder
Jun 10, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've signed the CLA ... Guess it's pending. |
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
=======================================
Coverage 90.14% 90.14%
=======================================
Files 4 4
Lines 355 355
Branches 75 75
=======================================
Hits 320 320
Misses 35 35
Continue to review full report at Codecov.
|
michael-ciniawsky
approved these changes
Jun 9, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gl2748 Thx
michael-ciniawsky
changed the title
fix: missing 'ignoreOrder' option details in breaking change error ou…
fix: add missing Jun 9, 2017
options.ignoreOrder
details in Error message
bebraw
approved these changes
Jun 10, 2017
alexander-akait
approved these changes
Jun 10, 2017
joshwiens
approved these changes
Jun 10, 2017
joshwiens
added
status: Approved
pr_action: Merge ready
and removed
severity: 5 (confusing)
pr_action: Review
status: Approved
labels
Jun 10, 2017
MirrorBytes
added a commit
to MirrorBytes/extract-text-webpack-plugin
that referenced
this pull request
Jun 13, 2017
fix: add missing `options.ignoreOrder` details in Error message (webpack-contrib#539)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#520 Adds an option: "ignoreOrder" this is not listed in the available options in the error output for this plugin. Which can be confusing.