Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix: add missing options.ignoreOrder details in Error message #539

Merged
merged 1 commit into from
Jun 10, 2017
Merged

fix: add missing options.ignoreOrder details in Error message #539

merged 1 commit into from
Jun 10, 2017

Conversation

gl2748
Copy link
Contributor

@gl2748 gl2748 commented Jun 9, 2017

#520 Adds an option: "ignoreOrder" this is not listed in the available options in the error output for this plugin. Which can be confusing.

@jsf-clabot
Copy link

jsf-clabot commented Jun 9, 2017

CLA assistant check
All committers have signed the CLA.

@gl2748
Copy link
Contributor Author

gl2748 commented Jun 9, 2017

I've signed the CLA ... Guess it's pending.

@codecov
Copy link

codecov bot commented Jun 9, 2017

Codecov Report

Merging #539 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #539   +/-   ##
=======================================
  Coverage   90.14%   90.14%           
=======================================
  Files           4        4           
  Lines         355      355           
  Branches       75       75           
=======================================
  Hits          320      320           
  Misses         35       35
Impacted Files Coverage Δ
index.js 91.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e81b883...63b149a. Read the comment docs.

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gl2748 Thx

@michael-ciniawsky michael-ciniawsky self-assigned this Jun 9, 2017
@michael-ciniawsky michael-ciniawsky added this to the 2.1.3 milestone Jun 9, 2017
@michael-ciniawsky michael-ciniawsky changed the title fix: missing 'ignoreOrder' option details in breaking change error ou… fix: add missing options.ignoreOrder details in Error message Jun 9, 2017
@michael-ciniawsky michael-ciniawsky merged commit dd43832 into webpack-contrib:master Jun 10, 2017
MirrorBytes added a commit to MirrorBytes/extract-text-webpack-plugin that referenced this pull request Jun 13, 2017
fix: add missing `options.ignoreOrder` details in Error message (webpack-contrib#539)
@michael-ciniawsky michael-ciniawsky modified the milestone: 3.0.1 Aug 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants