Fix loader query not overriding webpack config #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was making the change for #190 when I noticed this. Figured these are two separate changes, thus two PRs. |
Closed
jhnns
added a commit
that referenced
this pull request
Nov 22, 2015
Fix loader query not overriding webpack config
|
Thx! Shipped with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jtangelder I noticed the merging of config here didn't match the comment. This fixes it and adds a test. There wasn't a similar kind of test so... this is probably not how you'd write the test, but the new test does fail without the change to
index.js.