This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
fix(index): reduce memory consumption (cacheKey.hash)
#215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-ciniawsky
approved these changes
Jan 27, 2018
src/index.js
Outdated
| @@ -160,7 +161,7 @@ class UglifyJsPlugin { | |||
| 'uglifyjs-webpack-plugin': versions.plugin, | |||
| 'uglifyjs-webpack-plugin-options': this.options, | |||
| path: compiler.outputPath ? `${compiler.outputPath}/${file}` : file, | |||
| input, | |||
| inputHash: crypto.createHash('sha512').update(input).digest('hex'), | |||
There was a problem hiding this comment.
What other algos besides sha512 are available? (the shortest possible should be the way to go imho)
There was a problem hiding this comment.
Should we serialize the options separately and hash them aswell ?
There was a problem hiding this comment.
webpack appears to use md5 for other modules - probably for speed.
Should we serialize the options separately and hash them aswell ?
Although the options could also be hashed, it may be easier to debug with a plain text prefix. A case could be made for either way.
michael-ciniawsky
changed the title
cacheKey.hash)
|
#214 landed |
|
Thanks @evilebottnawi. I have confirmed that this fixes the issue described in #216. |
alexander-akait
force-pushed
the
issue-weboack-6389
branch
from
76106ec
to
64bc841
Compare
|
@michael-ciniawsky friendly ping, change to md5 |
alexander-akait
force-pushed
the
issue-weboack-6389
branch
from
64bc841
to
e2c660a
Compare
4 tasks
michael-ciniawsky
added
status: Approved
and removed
pr_action: Review
priority: 3 (required)
severity: 4 (inconvenient)
labels
This was referenced Jan 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues