Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect modules from chunks array #175

Merged
merged 1 commit into from
May 9, 2018
Merged

Collect modules from chunks array #175

merged 1 commit into from
May 9, 2018

Conversation

th0r
Copy link
Collaborator

@th0r th0r commented May 9, 2018

Fixes #174

Copy link
Member

@valscion valscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I wonder what has caused webpack to start outputting such stats JSON. This change makes sense to me 👍

@th0r
Copy link
Collaborator Author

th0r commented May 9, 2018

Huh, I wonder what has caused webpack to start outputting such stats JSON

I've upgraded out work project to webpack 4 recently and didn't notice any change in stats file format. Seems like angular guys post-process it in some way...

@th0r th0r merged commit bf86048 into master May 9, 2018
@th0r th0r deleted the 174-modules-in-chunks branch May 9, 2018 13:56
@valscion
Copy link
Member

valscion commented May 9, 2018

Yeah, I think I've seen a few issues that have had trouble with angular CLI output. This might fix them.

@vytautas-pranskunas-
Copy link

I see you have found an issue. When it is available in npm?

@valscion
Copy link
Member

valscion commented May 9, 2018

We'll let you know when we publish a version with this fix. Usually we do it quite soon after fixing issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants