Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable viewer websocket connection if mode is static #215

Merged
merged 1 commit into from Oct 16, 2018
Merged

Disable viewer websocket connection if mode is static #215

merged 1 commit into from Oct 16, 2018

Conversation

@sebastianhaeni
Copy link
Contributor

@sebastianhaeni sebastianhaeni commented Oct 16, 2018

Resolves #195

@jsf-clabot
Copy link

@jsf-clabot jsf-clabot commented Oct 16, 2018

CLA assistant check
All committers have signed the CLA.

@valscion
Copy link
Member

@valscion valscion commented Oct 16, 2018

Looks good to me. What do you think, @th0r?

@valscion valscion requested a review from th0r Oct 16, 2018
th0r
th0r approved these changes Oct 16, 2018
@th0r
Copy link
Collaborator

@th0r th0r commented Oct 16, 2018

Looks good. Thanks @sebastianhaeni!
@valscion could you publish a new version with this change because I don't have time right now?

@th0r th0r merged commit 5be7049 into webpack-contrib:master Oct 16, 2018
2 checks passed
@valscion
Copy link
Member

@valscion valscion commented Oct 16, 2018

@valscion could you publish a new version with this change because I don't have time right now?

Will do 👍

valscion added a commit that referenced this issue Oct 16, 2018
@valscion
Copy link
Member

@valscion valscion commented Oct 16, 2018

Published v3.0.3 with this change 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants