Add support for 'auto' option with analyzer port #281 #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Some issue with nightmare I think. Tests run fine on my pc |
|
Can we support |
|
Could you please also update this section in readme? |
|
Sorry about the delay, I had some projects to work on. Not sure if you got the notification, I've force pushed to keep the commit history clean. |
th0r
approved these changes
Jul 15, 2019
|
Everything is fine except some issue with the build on CI. Could you take a look at why it fails? |
|
@avin-kavish Thanks for the PR, merged! |
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a single line of quite self-explanatory code. But I'm happy to write tests, just not sure where.
The logic I went with was, if analyzer port is specified, (and) if it is 'auto' use 0, else use the specified value. If it is not specified, use 8888, the default.
Closes #281