Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added travis ci support for modern node versions #66

Closed
wants to merge 2 commits into from
Closed

Added travis ci support for modern node versions #66

wants to merge 2 commits into from

Conversation

amilajack
Copy link

No description provided.

@hiroppy
Copy link

hiroppy commented Jul 23, 2016

I think v0.10 is unnecessary.
v0.10 does not use in webpack.
https://github.com/webpack/webpack/blob/master/.travis.yml

@hiroppy
Copy link

hiroppy commented Jul 23, 2016

LGTM 👍
Can you please squash the commits?

@joshwiens
Copy link
Member

joshwiens commented Jul 23, 2016 •
edited
Loading

@amilajack - As a general rule of thumb, loader support in regards to CI needs to be inline with webpack

e.g.

sudo: false
language: node_js
os:
  - linux
  - osx
node_js:
  - node
  - "6"
  - "5"
  - "4"

I am taking care of the rest of the tasks to get the CI up to webpack standards in #69

@joshwiens
Copy link
Member

joshwiens commented Jul 23, 2016 •
edited
Loading

@abouthiroppy - You can squash on merge and for reference, we don't have access to the loader repos yet :(

@hemanth
Copy link
Contributor

hemanth commented Jul 24, 2016

@amilajack Would you please change the file as per @d3viant0ne suggestion?

This was referenced Jul 24, 2016
Closed
Merged
@hemanth hemanth closed this Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amilajack @hiroppy @joshwiens @hemanth