Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Enabling overridable error behavior #47

Closed
wants to merge 3 commits into from
Closed

Enabling overridable error behavior #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fd64d6
initial commit
mjhenkes Sep 8, 2017
084bdf4
Merge pull request #1 from mjhenkes/overridable_errors
mjhenkes Sep 11, 2017
06ee2d2
no message
mjhenkes Sep 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 41 additions & 21 deletions lib/MemoryFileSystem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function pathToArray(path) {
const nix = /^\//.test(path);
if(!nix) {
if(!/^[A-Za-z]:/.test(path)) {
throw new MemoryFileSystemError(errors.code.EINVAL, path);
return null;
}
path = path.replace(/[\\\/]+/g, "\\"); // multi slashs
path = path.split(/[\\\/]/);
Expand All @@ -55,6 +55,9 @@ class MemoryFileSystem {

meta(_path) {
const path = pathToArray(_path);
if (path === null) {
return this.throwError('meta', [_path], [errors.code.EINVAL, _path, "meta"]);
}
let current = this.data;
let i = 0;
for(; i < path.length - 1; i++) {
Expand Down Expand Up @@ -92,24 +95,27 @@ class MemoryFileSystem {
isSocket: falseFn
};
} else {
throw new MemoryFileSystemError(errors.code.ENOENT, _path, "stat");
return this.throwError('statSync', [_path], [errors.code.ENOENT, _path, "stat"]);
}
}

readFileSync(_path, optionsOrEncoding) {
const path = pathToArray(_path);
if (path === null) {
return this.throwError('readFileSync', [_path, optionsOrEncoding], [errors.code.EINVAL, _path, "meta"]);
}
let current = this.data;
let i = 0
for(; i < path.length - 1; i++) {
if(!isDir(current[path[i]]))
throw new MemoryFileSystemError(errors.code.ENOENT, _path, "readFile");
return this.throwError('readFileSync', [_path, optionsOrEncoding], [errors.code.ENOENT, _path, "readFile"]);
current = current[path[i]];
}
if(!isFile(current[path[i]])) {
if(isDir(current[path[i]]))
throw new MemoryFileSystemError(errors.code.EISDIR, _path, "readFile");
return this.throwError('readFileSync', [_path, optionsOrEncoding], [errors.code.EISDIR, _path, "readFile"]);
else
throw new MemoryFileSystemError(errors.code.ENOENT, _path, "readFile");
return this.throwError('readFileSync', [_path, optionsOrEncoding], [errors.code.ENOENT, _path, "readFile"]);
}
current = current[path[i]];
const encoding = typeof optionsOrEncoding === "object" ? optionsOrEncoding.encoding : optionsOrEncoding;
Expand All @@ -119,29 +125,35 @@ class MemoryFileSystem {
readdirSync(_path) {
if(_path === "/") return Object.keys(this.data).filter(Boolean);
const path = pathToArray(_path);
if (path === null) {
return this.throwError('readdirSync', [_path], [errors.code.EINVAL, _path, "meta"]);
}
let current = this.data;
let i = 0;
for(; i < path.length - 1; i++) {
if(!isDir(current[path[i]]))
throw new MemoryFileSystemError(errors.code.ENOENT, _path, "readdir");
return this.throwError('readdirSync', [_path], [errors.code.ENOENT, _path, "readdir"]);
current = current[path[i]];
}
if(!isDir(current[path[i]])) {
if(isFile(current[path[i]]))
throw new MemoryFileSystemError(errors.code.ENOTDIR, _path, "readdir");
return this.throwError('readdirSync', [_path], [errors.code.ENOTDIR, _path, "readdir"]);
else
throw new MemoryFileSystemError(errors.code.ENOENT, _path, "readdir");
return this.throwError('readdirSync', [_path], [errors.code.ENOENT, _path, "readdir"]);
}
return Object.keys(current[path[i]]).filter(Boolean);
}

mkdirpSync(_path) {
const path = pathToArray(_path);
if (path === null) {
return this.throwError('mkdirpSync', [_path], [errors.code.EINVAL, _path, "mkdirp"]);
}
if(path.length === 0) return;
let current = this.data;
for(let i = 0; i < path.length; i++) {
if(isFile(current[path[i]]))
throw new MemoryFileSystemError(errors.code.ENOTDIR, _path, "mkdirp");
return this.throwError('mkdirpSync', [_path], [errors.code.ENOTDIR, _path, "mkdirp"]);
else if(!isDir(current[path[i]]))
current[path[i]] = {"":true};
current = current[path[i]];
Expand All @@ -151,37 +163,41 @@ class MemoryFileSystem {

mkdirSync(_path) {
const path = pathToArray(_path);
if (path === null) {
return this.throwError('mkdirSync', [_path], [errors.code.EINVAL, _path, "mkdir"]);
}
if(path.length === 0) return;
let current = this.data;
let i = 0;
for(; i < path.length - 1; i++) {
if(!isDir(current[path[i]]))
throw new MemoryFileSystemError(errors.code.ENOENT, _path, "mkdir");
return this.throwError('mkdirSync', [_path], [errors.code.ENOENT, _path, "mkdir"]);
current = current[path[i]];
}
if(isDir(current[path[i]]))
throw new MemoryFileSystemError(errors.code.EEXIST, _path, "mkdir");
return this.throwError('mkdirSync', [_path], [errors.code.EEXIST, _path, "mkdir"]);
else if(isFile(current[path[i]]))
throw new MemoryFileSystemError(errors.code.ENOTDIR, _path, "mkdir");
return this.throwError('mkdirSync', [_path], [errors.code.ENOTDIR, _path, "mkdir"]);
current[path[i]] = {"":true};
return;
}

_remove(_path, name, testFn) {
const path = pathToArray(_path);
const operation = name === "File" ? "unlink" : "rmdir";
if(path.length === 0) {
throw new MemoryFileSystemError(errors.code.EPERM, _path, operation);
const fn = name === "File" ? "unlinkSync" : "rmdirSync";
if(path === null || path.length === 0) {
return this.throwError(fn, [_path], [errors.code.EPERM, _path, operation]);
}
let current = this.data;
let i = 0;
for(; i < path.length - 1; i++) {
if(!isDir(current[path[i]]))
throw new MemoryFileSystemError(errors.code.ENOENT, _path, operation);
return this.throwError(fn, [_path], [errors.code.ENOENT, _path, operation]);
current = current[path[i]];
}
if(!testFn(current[path[i]]))
throw new MemoryFileSystemError(errors.code.ENOENT, _path, operation);
return this.throwError(fn, [_path], [errors.code.ENOENT, _path, operation]);
delete current[path[i]];
return;
}
Expand All @@ -195,24 +211,24 @@ class MemoryFileSystem {
}

readlinkSync(_path) {
throw new MemoryFileSystemError(errors.code.ENOSYS, _path, "readlink");
return this.throwError('readlinkSync', [_path], [errors.code.ENOSYS, _path, "readlink"]);
}

writeFileSync(_path, content, optionsOrEncoding) {
if(!content && !optionsOrEncoding) throw new Error("No content");
const path = pathToArray(_path);
if(path.length === 0) {
throw new MemoryFileSystemError(errors.code.EISDIR, _path, "writeFile");
if(path === null || path.length === 0) {
return this.throwError('writeFileSync', [_path, content, optionsOrEncoding], [errors.code.EISDIR, _path, "writeFile"]);
}
let current = this.data;
let i = 0
for(; i < path.length - 1; i++) {
if(!isDir(current[path[i]]))
throw new MemoryFileSystemError(errors.code.ENOENT, _path, "writeFile");
return this.throwError('writeFileSync', [_path, content, optionsOrEncoding], [errors.code.ENOENT, _path, "writeFile"]);
current = current[path[i]];
}
if(isDir(current[path[i]]))
throw new MemoryFileSystemError(errors.code.EISDIR, _path, "writeFile");
return this.throwError('writeFileSync', [_path, content, optionsOrEncoding], [errors.code.EISDIR, _path, "writeFile"]);
const encoding = typeof optionsOrEncoding === "object" ? optionsOrEncoding.encoding : optionsOrEncoding;
current[path[i]] = optionsOrEncoding || typeof content === "string" ? new Buffer(content, encoding) : content;
return;
Expand Down Expand Up @@ -288,6 +304,10 @@ class MemoryFileSystem {
}
return callback();
}

throwError(fn, args, error) {
throw new MemoryFileSystemError(error[0], error[1], error[2]);
}
}

// async functions
Expand Down
23 changes: 20 additions & 3 deletions test/MemoryFileSystem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,19 @@ describe("errors", function() {
fs.readlinkSync("/test/dir/link");
}).should.throw();
});
it("should throw on throwError", function () {
var fs = new MemoryFileSystem();
(function() {
fs.throwError("fn", [], [errors.code.ENOSYS, _path, "fn"]);
}).should.throw();
});
it("should allow overridable errors", function() {
var fs = new MemoryFileSystem();
fs.throwError = function(fn, args, error) {
return 'fallback file';
};
fs.readFileSync("/test/dir").should.be.eql("fallback file");
});
});
describe("async", function() {
["stat", "readdir", "mkdirp", "rmdir", "unlink", "readlink"].forEach(function(methodName) {
Expand Down Expand Up @@ -367,11 +380,15 @@ describe("pathToArray", function() {
fs.pathToArray("/a/b/c").should.be.eql(["a", "b", "c"]);
fs.pathToArray("C:/a/b").should.be.eql(["C:", "a", "b"]);
fs.pathToArray("C:\\a\\b").should.be.eql(["C:", "a", "b"]);
fs.pathToArray("/a").should.be.eql(["a"]);
fs.pathToArray("/").should.be.eql([]);
});
it("should fail on invalid paths", function() {
(function() {
fs.pathToArray("0:/");
}).should.throw();
var fs = new MemoryFileSystem();
// eslint-disable-next-line no-unused-expressions
should(fs.pathToArray("0:/")).not.be.ok;
// eslint-disable-next-line no-unused-expressions
should(fs.pathToArray("")).not.be.ok;
});
});
describe("join", function() {
Expand Down