Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with IE11 (ducks for cover) #50

Closed
wmertens opened this issue Feb 13, 2018 · 4 comments
Closed

Doesn't work with IE11 (ducks for cover) #50

wmertens opened this issue Feb 13, 2018 · 4 comments

Comments

@wmertens
Copy link
Contributor

I am using this in an SPA and it's really great, but it turns out that the npm version uses class in the JS, so it's not ES5.

Would it be possible to provide the npm code as ES5 code? I don't know what the current best way to provide ES6 code is, but this is the only package that causes problems in the build for our IE users.

In the meantime I'll try some workaround like forcing a babel compilation of this package.

@ooflorent
Copy link
Member

I don't understand, are you shipping tapable into your bundle? tapable is just an utility used within webpack and its loaders/plugins. Could you detail what you are trying to achieve?

@wmertens
Copy link
Contributor Author

wmertens commented Mar 20, 2018 via email

@ooflorent
Copy link
Member

Since the library is targeting node 6+, I don't think we would transpile it. Your best option is to include it into your babel-loader (instead of exclude: /node_modules/).

@wmertens
Copy link
Contributor Author

Yes, I'm whitelisting it now. Fair enough, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants