-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use async / await for info command #494
Conversation
So just 8+ is supported as I already thought. |
🤦♂️ sorry about this. edit: I looked into this to make sure this wasn't something that was caused by my envinfo package. Turns out this was a side effect of moving webpack-cli to a mono repo. Looks like envinfo was upgraded across a major version (4.x=>5.x), which indeed did make the breaking change of moving from sync=>async. |
Why are you sorry and for what? |
I thought I had gone back and made PRs to upgrade everyone using older versions of envinfo already. Turns out I hadn't! |
Ah ok, didn't know it. Which is the "right" solution here which I can / should apply? |
This should work fine 👍 |
What kind of change does this PR introduce?
This PR fixes #493
Did you add tests for your changes?
No
If relevant, did you update the documentation?
Summary
Currently
webpack-cli info
fails as it returns a promise which is not directly resolved.Does this PR introduce a breaking change?
Probably requires a Node.js version which supports async / await.
Other information