Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: @webpack-cli/add not working on topScope and merge #795

Closed
rishabh3112 opened this issue Mar 18, 2019 · 2 comments · Fixed by #797
Closed

[BUG]: @webpack-cli/add not working on topScope and merge #795

rishabh3112 opened this issue Mar 18, 2019 · 2 comments · Fixed by #797
Labels

Comments

@rishabh3112
Copy link
Member

rishabh3112 commented Mar 18, 2019

Describe the bug
When we want to add something to topScope raises following error
Screenshot from 2019-03-18 20-10-56

What is the current behavior?
Currently this error raises as add-generator maps properties from optionsSchema of webpack. But this schema doesn't include properties that are part of configuration object we create in generator.

To Reproduce
Steps to reproduce the behavior:

  1. webpack add
  2. give answer as topScope

Expected behavior
Add items to topScope

Screenshots
uploaded above

Please paste the results of webpack-cli info here, and mention other relevant information


  System:
    OS: Linux 4.15 Ubuntu 18.04.2 LTS (Bionic Beaver)
    CPU: (3) x64 Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz
  Binaries:
    Node: 10.15.0 - ~/.nvm/versions/node/v10.15.0/bin/node
    Yarn: 1.13.0 - ~/.nvm/versions/node/v10.15.0/bin/yarn
    npm: 6.4.1 - ~/.nvm/versions/node/v10.15.0/bin/npm
  Browsers:
    Firefox: 65.0.1
  npmGlobalPackages:
    webpack-cli: 3.2.3
    webpack: 4.29.3

Additional context

@rishabh3112
Copy link
Member Author

On researching, I found there is same bug with merge too. For solving this I have two solutions:

  1. Take multi line input for the object to be merged
  2. Take location of config file with which user want to merge current configuration.
    Which approach is recommended ?

@evenstensberg
Copy link
Member

Location

@rishabh3112 rishabh3112 changed the title [BUG]: @webpack-cli/add not working on topScope [BUG]: @webpack-cli/add not working on topScope and merge Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants