Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improving contributing.md #1350

Merged
merged 4 commits into from
Mar 25, 2020
Merged

docs: improving contributing.md #1350

merged 4 commits into from
Mar 25, 2020

Conversation

himanshu010
Copy link
Contributor

fixes: #1349
What kind of change does this PR introduce?

improving docs
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
N/A
Summary

Does this PR introduce a breaking change?

Other information

@himanshu010 himanshu010 requested a review from a team as a code owner March 18, 2020 11:32
@himanshu010
Copy link
Contributor Author

@evilebottnawi can you review this

@alexander-akait
Copy link
Member

Please fix conflicts

@snitin315
Copy link
Member

Looks like supressed by #1354

@himanshu010
Copy link
Contributor Author

Please fix conflicts

@evilebottnawi done👍

anshumanv
anshumanv previously approved these changes Mar 20, 2020
View reviewed changes
@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

jamesgeorge007
jamesgeorge007 previously approved these changes Mar 20, 2020
View reviewed changes
snitin315
snitin315 requested changes Mar 21, 2020
View reviewed changes
Copy link
Member

@snitin315 snitin315 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this link it's no more present in the file. (Using Yarn)

.github/CONTRIBUTING.md Show resolved Hide resolved
@webpack-bot
Copy link

@himanshu010 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@snitin315 Please review the new changes.

@ghost
Copy link

ghost commented Mar 21, 2020

There were the following issues with this Pull Request

  • Commit: c58fd46
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

1 similar comment
@ghost
Copy link

ghost commented Mar 21, 2020

There were the following issues with this Pull Request

  • Commit: c58fd46
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Mar 21, 2020

There were the following issues with this Pull Request

  • Commit: c58fd46
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@himanshu010 himanshu010 mentioned this pull request Mar 24, 2020
Merged
alexander-akait
alexander-akait approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team need more reviews

@alexander-akait
Copy link
Member

There is no response from the team for a long time (7 days), so I will merge it

@alexander-akait alexander-akait merged commit c047af8 into webpack:next Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snitin315 snitin315 snitin315 requested changes

@alexander-akait alexander-akait alexander-akait approved these changes

@anshumanv anshumanv Awaiting requested review from anshumanv

@jamesgeorge007 jamesgeorge007 Awaiting requested review from jamesgeorge007

@wizardofhogwarts wizardofhogwarts Awaiting requested review from wizardofhogwarts

Assignees
No one assigned
Labels
PR: CI-ok PR: reviewed-approved PR: small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs(contributing.md): missing some content in the table
7 participants
@himanshu010 @alexander-akait @snitin315 @webpack-bot @anshumanv @jamesgeorge007 @wizardofhogwarts