Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add serveIndex icons #2441

Merged
merged 1 commit into from Mar 2, 2020
Merged

Conversation

jlguenego
Copy link
Contributor

@jlguenego jlguenego commented Feb 29, 2020

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Breaking Changes

Additional Info

@jlguenego
Copy link
Contributor Author

Related to Issue #2440

@jlguenego jlguenego closed this Feb 29, 2020
@jlguenego jlguenego reopened this Feb 29, 2020
@jlguenego
Copy link
Contributor Author

image

Folders now have icons in front of each file ;)

@codecov
Copy link

codecov bot commented Feb 29, 2020

Codecov Report

Merging #2441 into master will increase coverage by 0.22%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2441      +/-   ##
==========================================
+ Coverage   93.58%   93.81%   +0.22%     
==========================================
  Files          34       34              
  Lines        1309     1309              
  Branches      371      371              
==========================================
+ Hits         1225     1228       +3     
+ Misses         82       79       -3     
  Partials        2        2
Impacted Files Coverage Δ
lib/Server.js 96.73% <50%> (+0.43%) ⬆️
client-src/default/utils/reloadApp.js 100% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2da4a1e...45d687d. Read the comment docs.

@jlguenego
Copy link
Contributor Author

before this pull request, directory looked poor without icons:
image

@alexander-akait alexander-akait merged commit e953d01 into webpack:master Mar 2, 2020
@alexander-akait
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants