Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multi compiler mode with proxy #2905

Merged
merged 2 commits into from Dec 3, 2020
Merged

fix: multi compiler mode with proxy #2905

merged 2 commits into from Dec 3, 2020

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

fixes #2891

Breaking Changes

No

Additional Info

it is dirtly fix, because developer can have two configs with the devServer option, but in v3 and v4 we have limitation - only one configuration can have devServer, otherwise we use 0 index for configurations, we will fix it after refactor it to plugin (I think v5 or v4 after stable release)

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #2905 (d4ad655) into master (9e65c24) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2905      +/-   ##
==========================================
+ Coverage   92.52%   92.53%   +0.01%     
==========================================
  Files          37       37              
  Lines        1258     1260       +2     
  Branches      333      334       +1     
==========================================
+ Hits         1164     1166       +2     
  Misses         89       89              
  Partials        5        5              
Impacted Files Coverage Δ
lib/Server.js 94.88% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e65c24...d4ad655. Read the comment docs.

@alexander-akait alexander-akait merged commit 247a92b into master Dec 3, 2020
@alexander-akait alexander-akait deleted the issue-2891 branch December 3, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4.0.0-beta.0: dev server fails in multiple configs env with proxy property.
1 participant