Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty entries #2920

Merged
merged 4 commits into from Feb 17, 2021
Merged

fix: empty entries #2920

merged 4 commits into from Feb 17, 2021

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Dec 8, 2020

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

fixes #2876

Motivation / Use-Case

Use better API

Breaking Changes

No

Additional Info

WIP on tests

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #2920 (182346e) into master (4b48017) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2920      +/-   ##
==========================================
- Coverage   92.32%   92.30%   -0.02%     
==========================================
  Files          37       37              
  Lines        1264     1261       -3     
  Branches      328      327       -1     
==========================================
- Hits         1167     1164       -3     
  Misses         92       92              
  Partials        5        5              
Impacted Files Coverage Δ
lib/utils/updateCompiler.js 100.00% <ø> (ø)
lib/utils/DevServerPlugin.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b48017...a6fa2c5. Read the comment docs.

@alexander-akait
Copy link
Member Author

Rewriting tests will take a long time, we need to stop testing the internals of the webpack and focus on integration and e2e tests

@hiroppy
Copy link
Member

hiroppy commented Dec 9, 2020

ok so you will merge this pr even if CI fails?(if yes, it's better to skip tests failed

@alexander-akait
Copy link
Member Author

We need rewrite tests 😞

@alexander-akait
Copy link
Member Author

Not related to this issue, wrong public path

@alexander-akait
Copy link
Member Author

alexander-akait commented Jan 27, 2021

We have the issue for Module Federation, because it is not fully supported, please create reproducible test repo and put it there, this PR is not for helping, let's keep it only for the related problem

@csvan
Copy link

csvan commented Feb 11, 2021

@alexander-akait anything we can do to help get this merged?

})
.catch(done);
});
});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In future we should rewrite these tests on e2e with browser, i.e. run dev server, do some action and wait HMR or reload refresh using puppeter or playwright, we can do it in separate PR, should be interesting task

@snitin315 snitin315 marked this pull request as ready for review February 17, 2021 15:56
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-akait alexander-akait merged commit 45f6592 into master Feb 17, 2021
@alexander-akait alexander-akait deleted the issue-2876 branch February 17, 2021 15:59
@alexander-akait
Copy link
Member Author

Now we need test it on IE 11 and ensure all works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4.0.0-beta.0: Error: No dependency factory available for this dependency type: EntryDependency
5 participants