-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: empty entries #2920
fix: empty entries #2920
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2920 +/- ##
==========================================
- Coverage 92.32% 92.30% -0.02%
==========================================
Files 37 37
Lines 1264 1261 -3
Branches 328 327 -1
==========================================
- Hits 1167 1164 -3
Misses 92 92
Partials 5 5
Continue to review full report at Codecov.
|
Rewriting tests will take a long time, we need to stop testing the internals of the webpack and focus on integration and e2e tests |
ok so you will merge this pr even if CI fails?(if yes, it's better to skip tests failed |
We need rewrite tests 😞 |
Not related to this issue, wrong public path |
We have the issue for Module Federation, because it is not fully supported, please create reproducible test repo and put it there, this PR is not for helping, let's keep it only for the related problem |
@alexander-akait anything we can do to help get this merged? |
1d8456f
to
c41a47c
Compare
c41a47c
to
4f646db
Compare
}) | ||
.catch(done); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In future we should rewrite these tests on e2e with browser, i.e. run dev server, do some action and wait HMR
or reload
refresh using puppeter
or playwright
, we can do it in separate PR, should be interesting task
551abb1
to
a6fa2c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @alexander-akait
Now we need test it on IE 11 and ensure all works fine |
For Bugs and Features; did you add new tests?
fixes #2876
Motivation / Use-Case
Use better API
Breaking Changes
No
Additional Info
WIP on tests