fix: show correct url in output status #3013
Conversation
snitin315
force-pushed
the
fix/host
branch
2 times, most recently
from
255a8fd
to
0cc6b88
Compare
snitin315
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3013 +/- ##
==========================================
- Coverage 92.40% 92.32% -0.08%
==========================================
Files 37 37
Lines 1264 1264
Branches 328 328
==========================================
- Hits 1168 1167 -1
- Misses 91 92 +1
Partials 5 5
Continue to review full report at Codecov.
|
|
Please fix lint problem |
|
I shouldn't be able to commit if there is a lint issue until I bypass with |
|
I will fix ci tomorrow. |
|
Sorry about that, sometimes it passes locally but fails on CI. I will keep this in my mind and will use my fork's CI in the future in such a case. This one should be good now. |
|
Thanks |
| // skip if webpack-dev-server is not linked | ||
| let runCLITest = describe; | ||
| let basePath; | ||
|
|
||
| try { | ||
| basePath = path.join(require.resolve('webpack-dev-server'), '..', '..'); | ||
| } catch { | ||
| runCLITest = describe.skip; | ||
| } |
There was a problem hiding this comment.
This'd make tests fail where webpack-dev-server is not npm linked.
There was a problem hiding this comment.
We link it on CI before running tests.
There was a problem hiding this comment.
But for developers testing locally, it may be a hurdle.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
#2992 (comment)
Breaking Changes
None.
Additional Info
No