Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to open browser with --open-page #3032

Merged
merged 1 commit into from Feb 20, 2021
Merged

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Feb 19, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes.

Motivation / Use-Case

Fixes #2993

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #3032 (b569b5a) into master (9b6b5c1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3032   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files          37       37           
  Lines        1261     1261           
  Branches      327      327           
=======================================
  Hits         1164     1164           
  Misses         92       92           
  Partials        5        5           
Impacted Files Coverage Δ
lib/Server.js 94.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b6b5c1...b569b5a. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests?

@snitin315
Copy link
Member Author

Investigating how to add one for this.

@snitin315 snitin315 changed the title fix: use --open-page without explicitly mentioning --open fix: fix: allow to open browser with --open-page Feb 20, 2021
@snitin315 snitin315 changed the title fix: fix: allow to open browser with --open-page fix: allow to open browser with --open-page Feb 20, 2021
@snitin315
Copy link
Member Author

/cc @alexander-akait

@alexander-akait alexander-akait merged commit 581ee07 into master Feb 20, 2021
@alexander-akait alexander-akait deleted the fix-open branch February 20, 2021 12:42
@alexander-akait
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack 5 --open-page / devServer.openPage not opening page
2 participants