feat: improve output for IPv4 and IPv6 #3092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
reviewed
Mar 18, 2021
lib/Server.js
Outdated
Comment on lines
709
to
712
| const uri = | ||
| localhostForTerminal || | ||
| networkUrlForTerminalIPv6 || | ||
| networkUrlForTerminalIPv6; |
There was a problem hiding this comment.
Suggested change
| const uri = | |
| localhostForTerminal || | |
| networkUrlForTerminalIPv6 || | |
| networkUrlForTerminalIPv6; | |
| const uri = | |
| localhostForTerminal || | |
| networkUrlForTerminalIPv4 || | |
| networkUrlForTerminalIPv6; |
Codecov Report
@@ Coverage Diff @@
## master #3092 +/- ##
==========================================
- Coverage 92.30% 91.97% -0.34%
==========================================
Files 37 37
Lines 1261 1283 +22
Branches 328 343 +15
==========================================
+ Hits 1164 1180 +16
- Misses 92 97 +5
- Partials 5 6 +1
Continue to review full report at Codecov.
|
alexander-akait
force-pushed
the
feat-output-ipv4-and-ipv6
branch
from
15137d7
to
7533810
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Will add late
Motivation / Use-Case
finish #2943
Breaking Changes
No
Additional Info
output information for IPv4 and IPv6 + less deps, because
internal-ipusesipaddr.js