Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dev server endpoints #3101

Merged
merged 5 commits into from Apr 2, 2021
Merged

fix: dev server endpoints #3101

merged 5 commits into from Apr 2, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Will do it in future

Motivation / Use-Case

fixes #3023

Breaking Changes

No

Additional Info

No

hiroppy
hiroppy previously approved these changes Mar 24, 2021
@hiroppy hiroppy dismissed their stale review March 24, 2021 02:24

sorry, code looks good but e2e is red.

@alexander-akait
Copy link
Member Author

Yep, I will investigate why it was broken

@alexander-akait
Copy link
Member Author

Full refactor output, we should use stats to output assets, no need complex logic

@alexander-akait
Copy link
Member Author

Also we can improve it in future (size + other meta information), because we have stats here

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #3101 (d5d3ca5) into master (5d0d5af) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3101      +/-   ##
==========================================
+ Coverage   94.78%   94.94%   +0.16%     
==========================================
  Files          37       37              
  Lines        1207     1188      -19     
  Branches      325      323       -2     
==========================================
- Hits         1144     1128      -16     
+ Misses         57       54       -3     
  Partials        6        6              
Impacted Files Coverage Δ
lib/Server.js 94.02% <100.00%> (+0.41%) ⬆️
lib/utils/routes.js 100.00% <100.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d0d5af...d5d3ca5. Read the comment docs.

@alexander-akait alexander-akait merged commit b3374c3 into master Apr 2, 2021
@alexander-akait alexander-akait deleted the issue-3023 branch April 2, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] /webpack-dev-server file list endpoint not working
2 participants