feat: add watchFiles option #3136
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3136 +/- ##
==========================================
+ Coverage 94.94% 94.99% +0.04%
==========================================
Files 37 37
Lines 1206 1218 +12
Branches 332 338 +6
==========================================
+ Hits 1145 1157 +12
Misses 55 55
Partials 6 6
Continue to review full report at Codecov.
|
|
I will finish this PR, need small improvements |
alexander-akait
force-pushed
the
watch-files
branch
from
26159ca
to
681f8d7
Compare
|
/cc @anshumanv @snitin315 I make occasional mistakes sometimes, it would be nice to get more eyes |
lib/options.json
Outdated
| "port": "should be {Number|String|Null} (https://webpack.js.org/configuration/dev-server/#devserverport)", | ||
| "proxy": "should be {Object|Array} (https://webpack.js.org/configuration/dev-server/#devserverproxy)", | ||
| "public": "should be {String} (https://webpack.js.org/configuration/dev-server/#devserverpublic)", | ||
| "setupExitSignals": "should be {Boolean} (https://webpack.js.org/configuration/dev-server/#devserversetupexitsignals)", | ||
| "static": "should be {Boolean|String|Object|Array} (https://webpack.js.org/configuration/dev-server/#devserverstatic)", | ||
| "transportMode": "should be {String|Object} (https://webpack.js.org/configuration/dev-server/#devservertransportmode)" | ||
| "transportMode": "should be {String|Object} (https://webpack.js.org/configuration/dev-server/#devservertransportmode)", | ||
| "watchFiles": "should be {String|Array} (https://webpack.js.org/configuration/dev-server/#devserverwatchfiles)" |
There was a problem hiding this comment.
Just not, this is not work right now, we need move them to description property, also remove types, our default validator already print them in pretty way, just test
Should be easy task
|
will add docs after release |
bin/cli-flags.js
Outdated
| @@ -228,5 +228,16 @@ module.exports = { | |||
| multiple: true, | |||
| negative: true, | |||
| }, | |||
| { | |||
| name: 'watch-files', | |||
| type: [String], | |||
There was a problem hiding this comment.
| type: [String], | |
| type: String, |
For Bugs and Features; did you add new tests?
wip on tests
Motivation / Use-Case
Add watchFiles option to listen to user-defined file changes
Breaking Changes
Nope
Additional Info
Fix #3121