Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support fn in headers option #3267

Merged
merged 5 commits into from May 11, 2021
Merged

feat: support fn in headers option #3267

merged 5 commits into from May 11, 2021

Conversation

anshumanv
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

allow headers function for customizability

Breaking Changes

no

Additional Info

@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #3267 (d03b7f7) into master (335a6ed) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3267      +/-   ##
==========================================
+ Coverage   95.38%   95.39%   +0.01%     
==========================================
  Files          34       34              
  Lines        1236     1239       +3     
  Branches      352      353       +1     
==========================================
+ Hits         1179     1182       +3     
  Misses         51       51              
  Partials        6        6              
Impacted Files Coverage Δ
lib/Server.js 95.40% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 335a6ed...d03b7f7. Read the comment docs.

snitin315
snitin315 previously approved these changes May 8, 2021
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add small test

@anshumanv
Copy link
Member Author

sorry for delay, will do today

@anshumanv
Copy link
Member Author

@alexander-akait done

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge when CI will be green

@anshumanv anshumanv merged commit 28f9597 into master May 11, 2021
@anshumanv anshumanv deleted the headers-fn branch May 11, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants