fix: improve message for static content changes #3289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
requested review from
alexander-akait,
anshumanv,
hiroppy and
knagaitsev
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3289 +/- ##
==========================================
+ Coverage 95.70% 95.71% +0.01%
==========================================
Files 34 34
Lines 1280 1285 +5
Branches 369 371 +2
==========================================
+ Hits 1225 1230 +5
Misses 51 51
Partials 4 4
Continue to review full report at Codecov.
|
client-src/index.js
Outdated
| }, | ||
| 'static-changed': function staticChanged(file) { | ||
| log.info( | ||
| `${file || 'Content'} from static directory was changed. Reloading...` |
There was a problem hiding this comment.
Can we use ${file ? "${file}" : 'Content'} from static directory was changed. Reloading...? Better to use " for special words/paths/names/etc, it's much better for reading
alexander-akait
approved these changes
May 24, 2021
anshumanv
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
Improve logging.
Breaking Changes
No
Additional Info
None