Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add port auto #3297

Merged
merged 3 commits into from May 15, 2021
Merged

feat: add port auto #3297

merged 3 commits into from May 15, 2021

Conversation

anshumanv
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

updated

Motivation / Use-Case

add port "auto" because we resolve port on own when it's not supplied

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #3297 (495d4d5) into master (670966f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3297   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          34       34           
  Lines        1241     1241           
  Branches      354      354           
=======================================
  Hits         1184     1184           
  Misses         51       51           
  Partials        6        6           
Impacted Files Coverage Δ
lib/utils/findPort.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 670966f...495d4d5. Read the comment docs.

@anshumanv anshumanv merged commit 437c8d3 into master May 15, 2021
@anshumanv anshumanv deleted the port-auto branch May 15, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants