Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show plugin name in progress log #3337

Merged
merged 4 commits into from May 24, 2021
Merged

fix: show plugin name in progress log #3337

merged 4 commits into from May 24, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented May 24, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

Fix #3217

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #3337 (bffb997) into master (257e2eb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3337   +/-   ##
=======================================
  Coverage   95.69%   95.70%           
=======================================
  Files          34       34           
  Lines        1279     1280    +1     
  Branches      368      369    +1     
=======================================
+ Hits         1224     1225    +1     
  Misses         51       51           
  Partials        4        4           
Impacted Files Coverage Δ
client-src/index.js 90.65% <100.00%> (+0.08%) ⬆️
lib/Server.js 96.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 257e2eb...bffb997. Read the comment docs.

@alexander-akait alexander-akait merged commit b8a0932 into master May 24, 2021
@alexander-akait alexander-akait deleted the progress-args branch May 24, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send all arguments from the progress to the client, not only the first one.
2 participants