Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate firewall to allowedHosts option #3345

Merged
merged 8 commits into from May 28, 2021
Merged

fix: migrate firewall to allowedHosts option #3345

merged 8 commits into from May 28, 2021

Conversation

anshumanv
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

existing

Motivation / Use-Case

add more verbose option, firewall was misleading

Breaking Changes

yep

Additional Info

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #3345 (6f226a8) into master (2d68701) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3345      +/-   ##
==========================================
+ Coverage   95.63%   95.65%   +0.01%     
==========================================
  Files          33       33              
  Lines        1283     1288       +5     
  Branches      369      373       +4     
==========================================
+ Hits         1227     1232       +5     
  Misses         52       52              
  Partials        4        4              
Impacted Files Coverage Δ
lib/Server.js 95.80% <100.00%> (ø)
lib/utils/normalizeOptions.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d68701...6f226a8. Read the comment docs.

@anshumanv
Copy link
Member Author

@alexander-akait done

test/cli/cli.test.js Show resolved Hide resolved
lib/options.json Show resolved Hide resolved
@anshumanv
Copy link
Member Author

All done and rebased 👍

snitin315
snitin315 previously approved these changes May 27, 2021
@anshumanv
Copy link
Member Author

@snitin315 need some more changes, wip 👍

@alexander-akait
Copy link
Member

Finish your work

@alexander-akait
Copy link
Member

@snitin315 I think we can finish CLI options, in future when we add new options we need to add them in CLI, do you need help?

@alexander-akait
Copy link
Member

/cc @snitin315 @anshumanv need review

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@snitin315
Copy link
Member

@snitin315 I think we can finish CLI options, in future when we add new options we need to add them in CLI, do you need help?

Yeah, any help finishing tests is appreciated 👍🏻 .

@alexander-akait alexander-akait merged commit 81e4e55 into master May 28, 2021
@alexander-akait alexander-akait deleted the fire branch May 28, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants