-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: migrate firewall to allowedHosts option #3345
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3345 +/- ##
==========================================
+ Coverage 95.63% 95.65% +0.01%
==========================================
Files 33 33
Lines 1283 1288 +5
Branches 369 373 +4
==========================================
+ Hits 1227 1232 +5
Misses 52 52
Partials 4 4
Continue to review full report at Codecov.
|
@alexander-akait done |
All done and rebased 👍 |
@snitin315 need some more changes, wip 👍 |
Finish your work |
@snitin315 I think we can finish CLI options, in future when we add new options we need to add them in CLI, do you need help? |
/cc @snitin315 @anshumanv need review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good!
Yeah, any help finishing tests is appreciated 👍🏻 . |
For Bugs and Features; did you add new tests?
existing
Motivation / Use-Case
add more verbose option, firewall was misleading
Breaking Changes
yep
Additional Info