Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: host can't be null or empty string #3352

Merged
merged 2 commits into from May 26, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No need

Motivation / Use-Case

If you want to use 0.0.0.0 (i.e. default) just don't set the host option or set it to 0.0.0.0 (same for IPv6)

Breaking Changes

Yes

Additional Info

No

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #3352 (638b3bc) into master (7169c01) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3352   +/-   ##
=======================================
  Coverage   95.63%   95.63%           
=======================================
  Files          33       33           
  Lines        1283     1283           
  Branches      369      369           
=======================================
  Hits         1227     1227           
  Misses         52       52           
  Partials        4        4           
Impacted Files Coverage Δ
lib/utils/DevServerPlugin.js 98.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7169c01...638b3bc. Read the comment docs.

@alexander-akait
Copy link
Member Author

/cc @snitin315 @anikethsaha

@alexander-akait alexander-akait merged commit 216b0d3 into master May 26, 2021
@alexander-akait alexander-akait deleted the fix-host-can-not-be-null-or-empty-string branch May 26, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants