feat: allow string value for port
#3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3354 +/- ##
==========================================
+ Coverage 95.65% 95.67% +0.02%
==========================================
Files 33 33
Lines 1288 1295 +7
Branches 373 377 +4
==========================================
+ Hits 1232 1239 +7
Misses 52 52
Partials 4 4
Continue to review full report at Codecov.
|
anshumanv
reviewed
May 28, 2021
|
Added 👍🏻 |
anshumanv
previously approved these changes
May 28, 2021
There was a problem hiding this comment.
We also can have port: string and webSocketServer: { type: 'ws', options: { port: string } }, let's add these tests too, maybe will be great to move it in normalize and convert to Number to avoid working with different types:
if (typeof this.options.port === 'string' && this.options.port !== 'auto') {
this.options.port = Number(this.options.port)
}
// Same for `websocketUrl.port` and `webSocketServer.options.port`
alexander-akait
previously approved these changes
May 28, 2021
alexander-akait
approved these changes
May 28, 2021
anshumanv
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Motivation / Use-Case
Allow string for
client.webSocketURL.portBreaking Changes
None
Additional Info
No