-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: polling usage in watchFiles option #3366
Conversation
Not sure how to test this, maybe mock chokidar and check it's getting called by the correct config? |
Yep, right direction |
Codecov Report
@@ Coverage Diff @@
## master #3366 +/- ##
==========================================
+ Coverage 95.67% 95.76% +0.09%
==========================================
Files 33 33
Lines 1295 1299 +4
Branches 377 381 +4
==========================================
+ Hits 1239 1244 +5
+ Misses 52 51 -1
Partials 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @snitin315
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good!
For Bugs and Features; did you add new tests?
yet to
Motivation / Use-Case
Fix #3365
Breaking Changes
no
Additional Info