Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: polling usage in watchFiles option #3366

Merged
merged 4 commits into from May 31, 2021
Merged

fix: polling usage in watchFiles option #3366

merged 4 commits into from May 31, 2021

Conversation

anshumanv
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yet to

Motivation / Use-Case

Fix #3365

Breaking Changes

no

Additional Info

@anshumanv
Copy link
Member Author

Not sure how to test this, maybe mock chokidar and check it's getting called by the correct config?

@alexander-akait
Copy link
Member

maybe mock chokidar

Yep, right direction

lib/Server.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 29, 2021

Codecov Report

Merging #3366 (152ebb5) into master (879d1b0) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3366      +/-   ##
==========================================
+ Coverage   95.67%   95.76%   +0.09%     
==========================================
  Files          33       33              
  Lines        1295     1299       +4     
  Branches      377      381       +4     
==========================================
+ Hits         1239     1244       +5     
+ Misses         52       51       -1     
  Partials        4        4              
Impacted Files Coverage Δ
lib/Server.js 96.25% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 879d1b0...152ebb5. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@alexander-akait alexander-akait merged commit 2afb223 into master May 31, 2021
@alexander-akait alexander-akait deleted the 3365 branch May 31, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "poll" property name on watchFiles option
3 participants