Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not allow empty string for port #3372

Merged
merged 2 commits into from Jun 1, 2021
Merged

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

Don't allow empty strings for the port option.

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #3372 (9ef0fa8) into master (4feeb8f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3372   +/-   ##
=======================================
  Coverage   95.76%   95.76%           
=======================================
  Files          33       33           
  Lines        1299     1299           
  Branches      381      381           
=======================================
  Hits         1244     1244           
  Misses         51       51           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4feeb8f...9ef0fa8. Read the comment docs.

@snitin315 snitin315 merged commit 8c53102 into master Jun 1, 2021
@snitin315 snitin315 deleted the port-empty-string branch June 1, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants