Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass own logger in historyApiFallback #3373

Merged
merged 4 commits into from Jun 3, 2021
Merged

fix: pass own logger in historyApiFallback #3373

merged 4 commits into from Jun 3, 2021

Conversation

anshumanv
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

wip on tests

Motivation / Use-Case

when user enables logs we use inbuilt logger to log the stats

Breaking Changes

no

Additional Info

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #3373 (c12aacd) into master (8c53102) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3373      +/-   ##
==========================================
- Coverage   95.76%   95.71%   -0.06%     
==========================================
  Files          33       33              
  Lines        1299     1306       +7     
  Branches      381      385       +4     
==========================================
+ Hits         1244     1250       +6     
- Misses         51       52       +1     
  Partials        4        4              
Impacted Files Coverage Δ
lib/Server.js 96.26% <100.00%> (+0.01%) ⬆️
client-src/utils/createSocketURL.js 96.42% <0.00%> (-3.58%) ⬇️
lib/utils/normalizeOptions.js 98.38% <0.00%> (+0.01%) ⬆️
lib/utils/DevServerPlugin.js 97.22% <0.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c53102...c12aacd. Read the comment docs.

@alexander-akait alexander-akait marked this pull request as ready for review June 3, 2021 11:04
snitin315
snitin315 previously approved these changes Jun 3, 2021
@alexander-akait alexander-akait merged commit 3ba2fa5 into master Jun 3, 2021
@alexander-akait alexander-akait deleted the haf branch June 3, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants