Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to set client.webSocketURL.protocol #3380

Merged
merged 2 commits into from Jun 2, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

WIP on tests

Motivation / Use-Case

When you proxy webpack dev server and proxy uses https you can't change protocol of web socket client URL without this feature

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #3380 (689a173) into master (7e86922) will decrease coverage by 0.06%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3380      +/-   ##
==========================================
- Coverage   95.76%   95.70%   -0.07%     
==========================================
  Files          33       33              
  Lines        1299     1304       +5     
  Branches      381      384       +3     
==========================================
+ Hits         1244     1248       +4     
- Misses         51       52       +1     
  Partials        4        4              
Impacted Files Coverage Δ
client-src/utils/createSocketURL.js 96.42% <50.00%> (-3.58%) ⬇️
lib/utils/DevServerPlugin.js 97.22% <100.00%> (+0.05%) ⬆️
lib/utils/normalizeOptions.js 98.38% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e86922...689a173. Read the comment docs.

@alexander-akait alexander-akait merged commit 8998d6b into master Jun 2, 2021
@alexander-akait alexander-akait deleted the feat-allow-to-set-protocol branch June 2, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant