-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to close overlay #3433
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3433 +/- ##
==========================================
- Coverage 94.77% 94.28% -0.50%
==========================================
Files 34 33 -1
Lines 1360 1295 -65
Branches 403 400 -3
==========================================
- Hits 1289 1221 -68
- Misses 66 67 +1
- Partials 5 7 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add e2e/overlay.test.js
and add simple test?
yep lets add it |
@anshumanv I will write one couple tests today, so in future you will easy to add them more |
yep big thanks @alexander-akait! |
I'm tired of these tests, it is more stable right now, but still very flaky, 80% times of my time I spend on tests instead writing code |
ecefb30
to
b5fd6eb
Compare
For Bugs and Features; did you add new tests?
yet to
Motivation / Use-Case
add a button on the error overlay to manually allow closing the overlay
Breaking Changes
no
Additional Info
fixes #3361