-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: postpone initialize #3467
Merged
Merged
fix: postpone initialize #3467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshumanv
previously approved these changes
Jun 21, 2021
f8f1015
to
811d7d6
Compare
5a2216f
to
abc765e
Compare
Codecov Report
@@ Coverage Diff @@
## master #3467 +/- ##
==========================================
+ Coverage 94.35% 94.38% +0.02%
==========================================
Files 26 26
Lines 1276 1282 +6
Branches 402 405 +3
==========================================
+ Hits 1204 1210 +6
- Misses 66 67 +1
+ Partials 6 5 -1
Continue to review full report at Codecov.
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
WIP
Motivation / Use-Case
fixes #3351
Breaking Changes
No
Additional Info
postpone
initialize
so dev server plugin will use resolved host and port (when we useauto
for the "port" option orlocal-ipv4
/etc for "host")