Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: postpone initialize #3467

Merged
merged 33 commits into from Jun 23, 2021
Merged

fix: postpone initialize #3467

merged 33 commits into from Jun 23, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

WIP

Motivation / Use-Case

fixes #3351

Breaking Changes

No

Additional Info

postpone initialize so dev server plugin will use resolved host and port (when we use auto for the "port" option or local-ipv4/etc for "host")

anshumanv
anshumanv previously approved these changes Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #3467 (9b5833e) into master (0020f3e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3467      +/-   ##
==========================================
+ Coverage   94.35%   94.38%   +0.02%     
==========================================
  Files          26       26              
  Lines        1276     1282       +6     
  Branches      402      405       +3     
==========================================
+ Hits         1204     1210       +6     
- Misses         66       67       +1     
+ Partials        6        5       -1     
Impacted Files Coverage Δ
bin/cli-flags.js 100.00% <ø> (ø)
lib/Server.js 94.35% <100.00%> (+0.04%) ⬆️
lib/utils/DevServerPlugin.js 97.61% <100.00%> (+0.01%) ⬆️
lib/utils/normalizeOptions.js 96.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ad308...9b5833e. Read the comment docs.

@alexander-akait alexander-akait merged commit 80087de into master Jun 23, 2021
@alexander-akait alexander-akait deleted the issue-3351 branch June 23, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: web socket connection fails with @webpack-cli/serve@1.4.0 when using findPort
2 participants