Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ipc #3479

Merged
merged 31 commits into from Jun 28, 2021
Merged

feat: ipc #3479

merged 31 commits into from Jun 28, 2021

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Jun 23, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

return ipc

Breaking Changes

No

Additional Info

fix #3409
fix #3457

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #3479 (1eac0f9) into master (3247a07) will decrease coverage by 0.25%.
The diff coverage is 90.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3479      +/-   ##
==========================================
- Coverage   94.60%   94.35%   -0.26%     
==========================================
  Files          26       26              
  Lines        1280     1311      +31     
  Branches      405      416      +11     
==========================================
+ Hits         1211     1237      +26     
- Misses         64       69       +5     
  Partials        5        5              
Impacted Files Coverage Δ
bin/cli-flags.js 100.00% <ø> (ø)
lib/Server.js 94.42% <89.53%> (-0.61%) ⬇️
lib/utils/normalizeOptions.js 96.66% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3247a07...1eac0f9. Read the comment docs.

rishabh3112
rishabh3112 previously approved these changes Jun 25, 2021
@alexander-akait alexander-akait merged commit b559738 into master Jun 28, 2021
@alexander-akait alexander-akait deleted the feat-ipc branch June 28, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack 5 / devServer.socket miss
2 participants