Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: <url> pattern for open #3496

Merged
merged 8 commits into from Jul 1, 2021
Merged

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

Allow to open default generated URL in different browsers

Breaking Changes

No

Additional Info

No

snitin315
snitin315 previously approved these changes Jun 29, 2021
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #3496 (ff217b2) into master (caa78e6) will increase coverage by 0.08%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3496      +/-   ##
==========================================
+ Coverage   94.76%   94.85%   +0.08%     
==========================================
  Files          25       25              
  Lines        1299     1301       +2     
  Branches      412      415       +3     
==========================================
+ Hits         1231     1234       +3     
+ Misses         64       63       -1     
  Partials        4        4              
Impacted Files Coverage Δ
bin/cli-flags.js 100.00% <ø> (ø)
lib/Server.js 94.35% <91.66%> (-0.07%) ⬇️
lib/utils/normalizeOptions.js 97.17% <100.00%> (+0.50%) ⬆️
lib/utils/DevServerPlugin.js 98.61% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caa78e6...ff217b2. Read the comment docs.

@alexander-akait alexander-akait merged commit 7c7ccf9 into master Jul 1, 2021
@alexander-akait alexander-akait deleted the feat-url-pattern-in-open branch July 1, 2021 19:51
@snitin315 snitin315 mentioned this pull request Jul 2, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants