Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display documentation links on errors #3512

Merged
merged 5 commits into from Jul 17, 2021
Merged

feat: display documentation links on errors #3512

merged 5 commits into from Jul 17, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Breaking Changes

None

Additional Info

No

@alexander-akait
Copy link
Member

Maybe we should do it for all loaders and plugins and webpack itself too

alexander-akait
alexander-akait previously approved these changes Jul 5, 2021
@snitin315
Copy link
Member Author

Maybe we should do it for all loaders and plugins and webpack itself too

Good idea, I will update and send PRs 👍🏻

@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #3512 (002f768) into master (39cac6f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3512   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files          20       20           
  Lines        1287     1287           
  Branches      426      426           
=======================================
  Hits         1211     1211           
  Misses         71       71           
  Partials        5        5           
Impacted Files Coverage Δ
bin/cli-flags.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39cac6f...002f768. Read the comment docs.

@alexander-akait
Copy link
Member

we need fix CI problems

@snitin315
Copy link
Member Author

@alexander-akait fixed 👍🏻

@alexander-akait
Copy link
Member

@snitin315 please rebase

@snitin315
Copy link
Member Author

@alexander-akait done 👍🏻

@snitin315
Copy link
Member Author

fixing conflicts.

@snitin315 snitin315 changed the title refactor: update schema feat: display documentation links on errors Jul 14, 2021
@snitin315 snitin315 merged commit 54790ab into master Jul 17, 2021
@snitin315 snitin315 deleted the update-schema branch July 17, 2021 08:42
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have small problems in schema-utils, I thinking fix it before merge it...

@snitin315
Copy link
Member Author

We have small problems in schema-utils, I thinking fix it before merge it...

Oh, what needs to be fixed in schema-utils?

@alexander-akait
Copy link
Member

We don't add link for anyOf/etc, you can look at our snapshots

@snitin315
Copy link
Member Author

We don't add link for anyOf/etc, you can look at our snapshots

I will fix it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants